Repository navigation
fix(dev): ignore an unusable adk.web.backend-url instead of serving it - #1555
Closed
copybara-service[bot] wants to merge 1 commit into
Closed
copybara-service[bot] wants to merge 1 commit into
copybara-service[bot] wants to merge 1 commit into
Conversation
A value the dev UI cannot use - one with no scheme, no host, credentials, a query or a fragment - was still reported in `runtime-config.json`, so whatever it contained reached the browser while the UI carried on using the bundled address. Such a value is now ignored entirely, with a warning that names the fault and not the value, and the bundled `backendUrl` stands as if the property were unset. A usable value behaves as before. PiperOrigin-RevId: 987799265
copybara-service
Bot
force-pushed
the
test_987799265
branch
from
September 25, 2026 09:30
53041a3 to
91edb53
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(dev): ignore an unusable adk.web.backend-url instead of serving it
A value the dev UI cannot use - one with no scheme, no host, credentials, a
query or a fragment - was still reported in
runtime-config.json, so whateverit contained reached the browser while the UI carried on using the bundled
address. Such a value is now ignored entirely, with a warning that names the
fault and not the value, and the bundled
backendUrlstands as if the propertywere unset. A usable value behaves as before.