fix(sessions): reject a duplicate session id in FirestoreSessionService - #1554
Closed
copybara-service[bot] wants to merge 1 commit into
Closed
copybara-service[bot] wants to merge 1 commit into
copybara-service[bot] wants to merge 1 commit into
Conversation
- `createSession` used to overwrite a session whose id was already in use, keeping its old events. It now fails with `SessionException`; to reuse an id, delete the session first. - Session ids are unique per user across apps, so an id the same user already has under another app is rejected too. - New session documents store a `createToken` field, so a create that the client retried after a lost reply is not reported as a duplicate. PiperOrigin-RevId: 986983990
copybara-service
Bot
force-pushed
the
test_986983990
branch
from
September 28, 2026 12:47
ddee491 to
a07f689
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(sessions): reject a duplicate session id in FirestoreSessionService
createSessionused to overwrite a session whose id was already in use,keeping its old events. It now fails with
SessionException; to reuse an id,delete the session first.
has under another app is rejected too.
createTokenfield, so a create that theclient retried after a lost reply is not reported as a duplicate.