-
Notifications
You must be signed in to change notification settings - Fork 10.7k
align README header, badges, and image to center #15662
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
## Summary
Fixed deprecated HTML `align` attribute in README to use modern HTML5-compliant heading tag while maintaining centered layout for better long-term maintainability.
## Details
Replaced Markdown heading syntax (`# Gemini CLI`) with HTML `<h1>` tag to ensure proper centering within the `<div align="center">` block. The `align` attribute on divs is deprecated in HTML5, but remains the most practical solution for GitHub README files. Converting the heading to HTML ensures consistent rendering across all Markdown parsers while keeping the existing centered layout intact.
**Changes:**
- Converted `# Gemini CLI` to `<h1>Gemini CLI</h1>`
- Added blank lines around content blocks for proper Markdown parsing
- Maintained `align="center"` for GitHub README compatibility
## Related Issues
Addresses feedback regarding obsolete HTML5 attributes in documentation.
## How to Validate
1. View the README on GitHub
2. Verify that the title "Gemini CLI" appears centered
3. Confirm all badges are centered below the title
4. Check that the screenshot image is centered
5. Validate layout consistency across desktop and mobile views
**Expected result:** All content within the div should be visually centered with no layout shifts.
## Pre-Merge Checklist
- [x] Updated relevant documentation and README (if needed)
- [ ] Added/updated tests (if needed)
- [ ] Noted breaking changes (if any)
- [ ] Validated on required platforms/methods:
- [ ] MacOS
- [ ] npm run
- [ ] npx
- [ ] Docker
- [ ] Podman
- [ ] Seatbelt
- [ ] Windows
- [ ] npm run
- [ ] npx
- [ ] Docker
- [ ] Linux
- [ ] npm run
- [ ] npx
- [ ] Docker
**Note:** This is a documentation-only change that doesn't affect runtime behavior, so platform validation is not applicable.
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Summary of ChangesHello @ChickensLord8, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on enhancing the aesthetic appeal of the project's Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request aims to center-align the header content of the README.md file. The implementation correctly centers the title, badges, and screenshot. However, it fails to center the introductory description as stated in the pull request's summary and validation steps. I've provided a suggestion to fix this by moving the description text inside the main div container.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
|
Thank you for this improvement! Unfortunately, we want to avoid HTML in the Markdown files when possible. |
Summary
Centered all README content (title, badges, screenshot, and description) to improve visual presentation and create a more professional appearance for the project documentation.
Details
Wrapped the main README content in a
<div align="center">tag to center-align all elements including the project title, CI/version badges, screenshot, and introductory description. This provides a more polished and modern look for the project's landing page.Related Issues
N/A
How to Validate
Pre-Merge Checklist