Skip to content
This repository was archived by the owner on Dec 16, 2025. It is now read-only.

Conversation

@Giom-V
Copy link
Contributor

@Giom-V Giom-V commented Jul 1, 2024

Description of the change

Instead of using the GOOGLE_API_KEY by default, we're checking for the GEMINI_API_KEY ones first since its naming is less misleading. The GOOGLE_API_KEY is still kept for consistency.

Motivation

The Google API key can be misleading since it's not really an overall key for all of Google API and only for the Gemini ones.

Type of change

Choose one: Feature request

Checklist

  • I have performed a self-review of my code.
  • I have added detailed comments to my code where applicable.
  • I have verified that my change does not break existing code.
  • My PR is based on the latest changes of the main branch (if unsure, please run git pull --rebase upstream main).
  • I am familiar with the Google Style Guide for the language I have coded in.
  • I have read through the Contributing Guide and signed the Contributor License Agreement.

The Google API key can be misleading since it's not really an overall key for all of Google API and only for the Gemini ones.
@github-actions github-actions bot added status:awaiting review PR awaiting review from a maintainer component:python sdk Issue/PR related to Python SDK labels Jul 1, 2024
@MarkDaoust MarkDaoust merged commit 0f8f139 into google-gemini:main Jul 22, 2024
@github-actions github-actions bot removed the status:awaiting review PR awaiting review from a maintainer label Jul 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

component:python sdk Issue/PR related to Python SDK

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants