Skip to content

Commit af56fba

Browse files
authored
update outdated MySQL internals documentation links (#1714)
1 parent 2356566 commit af56fba

File tree

5 files changed

+15
-14
lines changed

5 files changed

+15
-14
lines changed

AUTHORS

+1
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,7 @@ Daniel Montoya <dsmontoyam at gmail.com>
3838
Daniel Nichter <nil at codenode.com>
3939
Daniël van Eeden <git at myname.nl>
4040
Dave Protasowski <dprotaso at gmail.com>
41+
Demouth <yuya at demouth.net>
4142
Diego Dupin <diego.dupin at gmail.com>
4243
Dirkjan Bussink <d.bussink at gmail.com>
4344
DisposaBoy <disposaboy at dby.me>

auth.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -305,7 +305,7 @@ func (mc *mysqlConn) auth(authData []byte, plugin string) ([]byte, error) {
305305
if !mc.cfg.AllowNativePasswords {
306306
return nil, ErrNativePassword
307307
}
308-
// https://dev.mysql.com/doc/internals/en/secure-password-authentication.html
308+
// https://dev.mysql.com/doc/dev/mysql-server/8.4.5/page_protocol_connection_phase_authentication_methods_native_password_authentication.html
309309
// Native password authentication only need and will need 20-byte challenge.
310310
authResp := scramblePassword(authData[:20], mc.cfg.Passwd)
311311
return authResp, nil

connector.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -162,7 +162,7 @@ func (c *connector) Connect(ctx context.Context) (driver.Conn, error) {
162162
// Handle response to auth packet, switch methods if possible
163163
if err = mc.handleAuthResult(authData, plugin); err != nil {
164164
// Authentication failed and MySQL has already closed the connection
165-
// (https://dev.mysql.com/doc/internals/en/authentication-fails.html).
165+
// (https://dev.mysql.com/doc/dev/mysql-server/latest/page_protocol_connection_phase.html#sect_protocol_connection_phase_fast_path_fails).
166166
// Do not send COM_QUIT, just cleanup and return the error.
167167
mc.cleanup()
168168
return nil, err

const.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ const (
3232
)
3333

3434
// MySQL constants documentation:
35-
// http://dev.mysql.com/doc/internals/en/client-server-protocol.html
35+
// https://dev.mysql.com/doc/dev/mysql-server/latest/PAGE_PROTOCOL.html
3636

3737
const (
3838
iOK byte = 0x00

packets.go

+11-11
Original file line numberDiff line numberDiff line change
@@ -322,7 +322,7 @@ func (mc *mysqlConn) initCapabilities(serverCapabilities capabilityFlag, serverE
322322
}
323323

324324
// Client Authentication Packet
325-
// http://dev.mysql.com/doc/internals/en/connection-phase-packets.html#packet-Protocol::HandshakeResponse
325+
// https://dev.mysql.com/doc/dev/mysql-server/latest/page_protocol_connection_phase_packets_protocol_handshake_response.html
326326
func (mc *mysqlConn) writeHandshakeResponsePacket(authResp []byte, plugin string) error {
327327
// packet header 4
328328
// capabilities 4
@@ -419,7 +419,7 @@ func (mc *mysqlConn) writeHandshakeResponsePacket(authResp []byte, plugin string
419419
return mc.writePacket(data)
420420
}
421421

422-
// http://dev.mysql.com/doc/internals/en/connection-phase-packets.html#packet-Protocol::AuthSwitchResponse
422+
// https://dev.mysql.com/doc/dev/mysql-server/latest/page_protocol_connection_phase_packets_protocol_auth_switch_response.html
423423
func (mc *mysqlConn) writeAuthSwitchPacket(authData []byte) error {
424424
pktLen := 4 + len(authData)
425425
data, err := mc.buf.takeBuffer(pktLen)
@@ -517,7 +517,7 @@ func (mc *mysqlConn) readAuthResult() ([]byte, string, error) {
517517

518518
case iEOF:
519519
if len(data) == 1 {
520-
// https://dev.mysql.com/doc/internals/en/connection-phase-packets.html#packet-Protocol::OldAuthSwitchRequest
520+
// https://dev.mysql.com/doc/dev/mysql-server/latest/page_protocol_connection_phase_packets_protocol_old_auth_switch_request.html
521521
return nil, "mysql_old_password", nil
522522
}
523523
pluginEndIndex := bytes.IndexByte(data, 0x00)
@@ -585,7 +585,7 @@ func (mc *okHandler) readResultSetHeaderPacket() (int, bool, error) {
585585
}
586586

587587
// Error Packet
588-
// http://dev.mysql.com/doc/internals/en/generic-response-packets.html#packet-ERR_Packet
588+
// https://dev.mysql.com/doc/dev/mysql-server/latest/page_protocol_basic_err_packet.html
589589
func (mc *mysqlConn) handleErrorPacket(data []byte) error {
590590
if data[0] != iERR {
591591
return ErrMalformPkt
@@ -667,7 +667,7 @@ func (mc *mysqlConn) clearResult() *okHandler {
667667
}
668668

669669
// Ok Packet
670-
// http://dev.mysql.com/doc/internals/en/generic-response-packets.html#packet-OK_Packet
670+
// https://dev.mysql.com/doc/dev/mysql-server/latest/page_protocol_basic_ok_packet.html
671671
func (mc *okHandler) handleOkPacket(data []byte) error {
672672
var n, m int
673673
var affectedRows, insertId uint64
@@ -701,7 +701,7 @@ func (mc *okHandler) handleOkPacket(data []byte) error {
701701
}
702702

703703
// Read Packets as Field Packets until EOF-Packet or an Error appears
704-
// http://dev.mysql.com/doc/internals/en/com-query-response.html#packet-Protocol::ColumnDefinition41
704+
// https://dev.mysql.com/doc/dev/mysql-server/latest/page_protocol_com_query_response_text_resultset_column_definition.html#sect_protocol_com_query_response_text_resultset_column_definition_41
705705
func (mc *mysqlConn) readColumns(count int, old []mysqlField) ([]mysqlField, error) {
706706
columns := make([]mysqlField, count)
707707
if len(old) != count {
@@ -806,7 +806,7 @@ func (mc *mysqlConn) readColumns(count int, old []mysqlField) ([]mysqlField, err
806806
}
807807

808808
// Read Packets as Field Packets until EOF-Packet or an Error appears
809-
// http://dev.mysql.com/doc/internals/en/com-query-response.html#packet-ProtocolText::ResultsetRow
809+
// https://dev.mysql.com/doc/dev/mysql-server/latest/page_protocol_com_query_response_text_resultset_row.html
810810
func (rows *textRows) readRow(dest []driver.Value) error {
811811
mc := rows.mc
812812

@@ -968,7 +968,7 @@ func (mc *mysqlConn) skipRows() error {
968968
******************************************************************************/
969969

970970
// Prepare Result Packets
971-
// http://dev.mysql.com/doc/internals/en/com-stmt-prepare-response.html
971+
// https://dev.mysql.com/doc/dev/mysql-server/latest/page_protocol_com_stmt_prepare.html#sect_protocol_com_stmt_prepare_response
972972
func (stmt *mysqlStmt) readPrepareResultPacket() (uint16, error) {
973973
data, err := stmt.mc.readPacket()
974974
if err == nil {
@@ -995,7 +995,7 @@ func (stmt *mysqlStmt) readPrepareResultPacket() (uint16, error) {
995995
return 0, err
996996
}
997997

998-
// http://dev.mysql.com/doc/internals/en/com-stmt-send-long-data.html
998+
// https://dev.mysql.com/doc/dev/mysql-server/latest/page_protocol_com_stmt_send_long_data.html
999999
func (stmt *mysqlStmt) writeCommandLongData(paramID int, arg []byte) error {
10001000
maxLen := stmt.mc.maxAllowedPacket - 1
10011001
pktLen := maxLen
@@ -1043,7 +1043,7 @@ func (stmt *mysqlStmt) writeCommandLongData(paramID int, arg []byte) error {
10431043
}
10441044

10451045
// Execute Prepared Statement
1046-
// http://dev.mysql.com/doc/internals/en/com-stmt-execute.html
1046+
// https://dev.mysql.com/doc/dev/mysql-server/latest/page_protocol_com_stmt_execute.html
10471047
func (stmt *mysqlStmt) writeExecutePacket(args []driver.Value) error {
10481048
if len(args) != stmt.paramCount {
10491049
return fmt.Errorf(
@@ -1264,7 +1264,7 @@ func (mc *okHandler) discardResults() error {
12641264
return nil
12651265
}
12661266

1267-
// http://dev.mysql.com/doc/internals/en/binary-protocol-resultset-row.html
1267+
// https://dev.mysql.com/doc/dev/mysql-server/latest/page_protocol_binary_resultset.html#sect_protocol_binary_resultset_row
12681268
func (rows *binaryRows) readRow(dest []driver.Value) error {
12691269
data, err := rows.mc.readPacket()
12701270
if err != nil {

0 commit comments

Comments
 (0)