Skip to content

Surface fetch/pull/push kill_after_timeout and reset default to None #1340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Byron merged 17 commits into from
Sep 18, 2021
Merged

Surface fetch/pull/push kill_after_timeout and reset default to None #1340

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
aafb300
change default fetch timeout to 60 s
sroet Sep 10, 2021
1d26515
allow for timeout propagation
sroet Sep 10, 2021
febd4fe
add test timeout with the old 10 s timeout
sroet Sep 10, 2021
4113d01
also test a call to 'push' with 10s timeout
sroet Sep 10, 2021
c55a8e3
propagate kwargs in do_test_fetch
sroet Sep 10, 2021
7df33f3
reset default timeout to None
sroet Sep 10, 2021
b555764
update docstring
sroet Sep 10, 2021
6b358f9
reuse kill_after_timeout kwarg
sroet Sep 13, 2021
3a81850
update tests and add a comment about different behaviour of 'push' vs…
sroet Sep 13, 2021
d41d537
go for pytest.raises and test that the functions run
sroet Sep 13, 2021
5531323
make flake8 and mypy happy
sroet Sep 14, 2021
da68bb1
fix typo's
sroet Sep 14, 2021
9678226
make test timeout stricter
sroet Sep 14, 2021
a9e43e5
fetch is also to quick on CI, only test pull
sroet Sep 14, 2021
5081881
two spaces before comments
sroet Sep 14, 2021
083039a
set timeout to a non-zero value
sroet Sep 14, 2021
e058c4c
Add a way to force status codes inside AutoInterrupt._terminate, and …
sroet Sep 15, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
go for pytest.raises and test that the functions run
  • Loading branch information
@sroet
sroet committed Sep 13, 2021
commit d41d5378353d5045064a1143a349b728c6f2dd80
6 changes: 3 additions & 3 deletions test/test_remote.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -661,7 +661,7 @@ def test_timeout_funcs(self, repo):
for function in ["pull", "fetch"]: #"can't get push to reliably timeout
f = getattr(repo.remotes.origin, function)
assert f is not None # Make sure these functions exist

with self.assertRaisesRegex(GitCommandError,
"kill_after_timeout=0.01 s"):
_ = f() # Make sure the function runs
with pytest.raises(GitCommandError,
match="kill_after_timeout=0.01 s"):
f(kill_after_timeout=0.01)