fix(nextjs): Export captureRouterTransitionStart from server entry as noop#19951
Draft
fix(nextjs): Export captureRouterTransitionStart from server entry as noop#19951
Conversation
…as noop Linters using `import/namespace` (eslint-plugin-import, oxlint) resolve `@sentry/nextjs` to the server entry point (`index.server.js`) rather than the `types` condition. Since `captureRouterTransitionStart` was only exported from the client entry, linters reported it as missing from the namespace. Add a server-side noop stub (matching the existing pattern for `showReportDialog`) and an explicit re-export in `index.types.ts` to resolve the `export *` ambiguity. Fixes #19939 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
Semver Impact of This PR🟢 Patch (bug fixes) 📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨Deps
Bug Fixes 🐛Cloudflare
Core
Deps
Other
Internal Changes 🔧Deps Dev
Nuxt
Other
🤖 This preview updates automatically when you update the PR. |
Contributor
size-limit report 📦
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
captureRouterTransitionStartinpackages/nextjs/src/server/index.ts, matching the existing pattern used forshowReportDialogindex.types.tsto resolve theexport *ambiguity between client and serverRoot Cause
Linters using
import/namespacerules (eslint-plugin-import, oxlint) resolve@sentry/nextjsto the server entry point (index.server.js) via Node resolution, not thetypescondition. SincecaptureRouterTransitionStartwas only exported from the client entry, linters reported it as missing from the namespace.Test plan
yarn build:devpassescaptureRouterTransitionStartas missingFixes #19939
🤖 Generated with Claude Code