Skip to content
This repository was archived by the owner on Dec 31, 2022. It is now read-only.
This repository was archived by the owner on Dec 31, 2022. It is now read-only.

support TS-style comment annotations #3

Open

Description

Activity

  1. self-assigned this
    on Jul 11, 2015
  2. getify commented on Jul 11, 2015

    @getify
    OwnerAuthor

    One potential issue, which may require this to be behind a flag instead of automatic: typescript may have a different interpretation of relative URLs than scantree uses. For example, TypeScript (and IDEs) may assume that a "../foo/bar.js" path is relative to the file it's included in, rather than relative to some base path setting (as scantree does).

    If so, I could change the assumptions about relativity for typescript pathing, but I don't know if I could practically do so on a per-path basis (strings are all that's passed around internally). It might be a flag you have to pass (--file-relative) which changes the definition of "relative" to "relative to current file" instead of "relative to base-path".

  3. getify commented on Jul 11, 2015

    @getify
    OwnerAuthor

    So, basic support for this should now be in there as of 0.3.0-a. But need to work out if the --file-relative option is necessary to fully support how people use typescript annotations with relative paths. Will leave this open for now as we investigate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions