Exclude frequenz-repo-config from dependabot grouping#368
Merged
llucax merged 4 commits intofrequenz-floss:v0.x.xfrom Mar 28, 2025
Merged
Exclude frequenz-repo-config from dependabot grouping#368llucax merged 4 commits intofrequenz-floss:v0.x.xfrom
llucax merged 4 commits intofrequenz-floss:v0.x.xfrom
Conversation
github-actions
Bot
added
the
part:template
This was referenced Mar 26, 2025
Merged
llucax
force-pushed
the
repo-config-dependabot
branch
from
ee98a57 to
8a713b6
Compare
Contributor
Author
|
This doesn't seem to be working properly for some reason, as usual things that appears to be simple can take quite a bit of time, specially when dependabot is involved, as the documentation sucks and it is very hard to know why it does what it does (or it doesn't). |
We group patch updates as they should always work. We also group minor updates, as it works too for most libraries, typically except libraries that don't have a stable release yet (v0.x.x branch), so we make some exceptions for them. Major updates and dependencies excluded by the above groups are still managed, but they'll create one PR per dependency, as breakage is expected, so it might need manual intervention. Finally, we group some dependencies that are related to each other, and usually needs to be updated together. Signed-off-by: Leandro Lucarella <luca-frequenz@llucax.com>
llucax
force-pushed
the
repo-config-dependabot
branch
from
8a713b6 to
eafe2a4
Compare
Contributor
Author
|
If finally worked, but it took a while to find a grouping that made sense. Updated and ready to merge. |
cwasicki
reviewed
Mar 27, 2025
Contributor
cwasicki
left a comment
cwasicki
left a comment
There was a problem hiding this comment.
Don't have an in-depth understanding of the repo, but apart from minor comment looks good.
| - "pytest-asyncio" | ||
| # We group repo-config updates as it uses optional dependencies that are | ||
| # considered different dependencies otherwise, and will create one PR for | ||
| # each if we don't group them. |
Contributor
There was a problem hiding this comment.
This comment looks misplaced.
Contributor
Author
There was a problem hiding this comment.
Misspelled how, my editor doesn't show any spelling issues :-/
Contributor
Author
There was a problem hiding this comment.
misplaced not misspelled 🤦
Fixed.
Signed-off-by: Leandro Lucarella <luca-frequenz@llucax.com>
llucax
force-pushed
the
repo-config-dependabot
branch
from
eafe2a4 to
cc836b4
Compare
Signed-off-by: Leandro Lucarella <luca-frequenz@llucax.com>
Signed-off-by: Leandro Lucarella <luca-frequenz@llucax.com>
llucax
force-pushed
the
repo-config-dependabot
branch
from
cc836b4 to
1f33af3
Compare
cwasicki
approved these changes
Mar 28, 2025
Contributor
Author
|
Force-merging as @cwasicki is not an codeowner. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since we are still in development (at branch v0.x.x), breaking changes can be introduced by minor (and even patch) updates, blocking many dependabot PRs as updates of this library fail or need manual intervention.
With this
frequenz-repo-configupdates will be done in a separate PR.Fixes #366.