Skip to content

Fix a11y contrast for pre-test message in flutter_test #180348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ashoknarayan wants to merge 4 commits into
base: master
Choose a base branch
from
+3 −3
Open

Fix a11y contrast for pre-test message in flutter_test #180348

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7f6530e
Update deprecation template to include required v-prefixed version
Dec 27, 2025
3fc7af9
Fix deprecation validator error message to include required leading v
Dec 27, 2025
201437c
Fix a11y contrast for pre-test message in flutter_test
Dec 28, 2025
1c1c83f
Merge branch 'master' into contrast-fix
ashoknarayan Dec 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion dev/bots/analyze.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -758,7 +758,7 @@ class _DeprecationMessagesVisitor extends RecursiveAstVisitor<void> {
_addErrorWithLineInfo(
versionLiteral,
error:
'Deprecation notice must end with a line saying "This feature was deprecated after...".',
'Deprecation notice must end with a line saying "This feature was deprecated after v<version>." (include the leading "v").',
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Dec 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This change, which updates the error message for deprecation notices, and the related documentation update in docs/contributing/Tree-hygiene.md, are unrelated to the main purpose of this pull request (fixing an accessibility contrast issue). To maintain a clean and understandable commit history, please move these changes to a separate pull request.

);
return;
}
Expand Down
2 changes: 1 addition & 1 deletion docs/contributing/Tree-hygiene.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -483,7 +483,7 @@ In other words:
@Deprecated(
'[description of how to migrate] '
'[brief motivation for why we are breaking the API] '
'This feature was deprecated after [beta version at time of deprecation].'
'This feature was deprecated after v[beta version at time of deprecation].'
)
```

Expand Down
2 changes: 1 addition & 1 deletion packages/flutter_test/lib/src/binding.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1265,7 +1265,7 @@ abstract class TestWidgetsFlutterBinding extends BindingBase
return announcements;
}

static const TextStyle _messageStyle = TextStyle(color: Color(0xFF917FFF), fontSize: 40.0);
static const TextStyle _messageStyle = TextStyle(color: Color(0xFF8F7FFF), fontSize: 40.0);

static const Widget _preTestMessage = Center(
child: Text('Test starting...', style: _messageStyle, textDirection: TextDirection.ltr),
Expand Down