-
Notifications
You must be signed in to change notification settings - Fork 29.8k
Fix a11y contrast for pre-test message in flutter_test #180348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request correctly fixes an accessibility contrast issue for test messages. However, it also includes unrelated changes to the deprecation message format. To maintain a clean commit history, it's best practice to keep pull requests focused on a single logical change. I've added a comment recommending that the unrelated changes be moved to a separate pull request. If the PR is not split, the description should be updated to mention all the changes.
| versionLiteral, | ||
| error: | ||
| 'Deprecation notice must end with a line saying "This feature was deprecated after...".', | ||
| 'Deprecation notice must end with a line saying "This feature was deprecated after v<version>." (include the leading "v").', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change, which updates the error message for deprecation notices, and the related documentation update in docs/contributing/Tree-hygiene.md, are unrelated to the main purpose of this pull request (fixing an accessibility contrast issue). To maintain a clean and understandable commit history, please move these changes to a separate pull request.
7f1b45a to
201437c
Compare
|
An existing Git SHA, To re-trigger presubmits after closing or re-opeing a PR, or pushing a HEAD commit (i.e. with |
Pre-launch Checklist
///).Works done