Skip to content

Conversation

@ashoknarayan
Copy link

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • I followed the [breaking change policy] and added [Data Driven Fixes] where supported.
  • All existing and new tests are passing.

Works done

  • The pre-test message "Test starting..." had a contrast ratio of 2.99:1 against the background.
  • This PR slightly adjusts the text color to 0xFF8F7FFF to meet the 3:1 minimum contrast ratio for accessibility.
  • Tested by running flutter_test.

@google-cla
Copy link

google-cla bot commented Dec 28, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@github-actions github-actions bot added a: tests "flutter test", flutter_test, or one of our tests c: contributor-productivity Team-specific productivity, code health, technical debt. framework flutter/packages/flutter repository. See also f: labels. d: docs/ flutter/flutter/docs, for contributors labels Dec 28, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly fixes an accessibility contrast issue for test messages. However, it also includes unrelated changes to the deprecation message format. To maintain a clean commit history, it's best practice to keep pull requests focused on a single logical change. I've added a comment recommending that the unrelated changes be moved to a separate pull request. If the PR is not split, the description should be updated to mention all the changes.

versionLiteral,
error:
'Deprecation notice must end with a line saying "This feature was deprecated after...".',
'Deprecation notice must end with a line saying "This feature was deprecated after v<version>." (include the leading "v").',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This change, which updates the error message for deprecation notices, and the related documentation update in docs/contributing/Tree-hygiene.md, are unrelated to the main purpose of this pull request (fixing an accessibility contrast issue). To maintain a clean and understandable commit history, please move these changes to a separate pull request.

@fluttergithubbot
Copy link
Contributor

An existing Git SHA, 1c1c83f3d1971c20e544a305c5b42ef0b6ded059, was detected, and no actions were taken.

To re-trigger presubmits after closing or re-opeing a PR, or pushing a HEAD commit (i.e. with --force) that already was pushed before, push a blank commit (git commit --allow-empty -m "Trigger Build") or rebase to continue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a: tests "flutter test", flutter_test, or one of our tests c: contributor-productivity Team-specific productivity, code health, technical debt. d: docs/ flutter/flutter/docs, for contributors framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants