Added command line options to override those in benchmark file. #99
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er to protect against bad user input
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's the user provide the following options on the command line to override those options in the benchmark file:
baseUrl - (no default, must be provided on command line or contained in benchmark file)
concurrency - defaults to 1 if no benchmark file is provided
iterations - defaults to 1 if no benchmark file is provided
rampup - defaults to 0 if no benchmark file is provided.
Note that this makes providing a benchmark file optional.
This commit also changes a few types and function signatures to better protect against bad user input.