[DevTools] Show Transition indicator when "suspended by" rows are expanded#34565
Merged
eps1lon merged 2 commits intofacebook:mainfrom Sep 26, 2025
Conversation
sebmarkbage
approved these changes
Sep 25, 2025
a410f6f to
f84631b
Compare
sebmarkbage
pushed a commit
to sebmarkbage/react
that referenced
this pull request
Sep 26, 2025
EugeneChoi4
pushed a commit
to EugeneChoi4/react
that referenced
this pull request
Sep 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This can actually take a while on real apps so without any progress indication it looked like it was broken.
We could use React's default Transition indicator but outside of a nprogress-like implementation I'm not sure what to pick.
So I just went with a waiting cursor for now just to get at least some signal out that something is happening.