[DevTools] Show Owner Stacks in "rendered by" View#34130
Merged
sebmarkbage merged 7 commits intofacebook:mainfrom Aug 11, 2025
Merged
[DevTools] Show Owner Stacks in "rendered by" View#34130sebmarkbage merged 7 commits intofacebook:mainfrom
sebmarkbage merged 7 commits intofacebook:mainfrom
Conversation
This is the debug stack that makes up the owner stack. I.e. the stack of the JSX call. Exclude if it has no owner since we don't use the root in owner stacks.
…e location exists This is useful to jump to the creation of a built-in like <div> or <Suspense>.
217d04e to
7623ef2
Compare
7d41b15 to
113825e
Compare
eps1lon
approved these changes
Aug 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This shows the stack trace of the JSX at each level so now you can also jump to the code location for the JSX callsite. The visual is similar to the owner stacks with
createTaskexcept when you click the<...>you jump to the Instance in the Components panel.I'm not sure it's really necessary to have all the JSX stacks of every owner. We could just have it for the current component and then the rest of the owners you could get to if you just click that owner instance.
As a bonus, I also use the JSX callsite as the fallback for the "View Source" button. This is primarily useful for built-ins like
<div>and<Suspense>that don't have any implementation to jump to anyway. It's useful to be able to jump to where a boundary was defined.