Fix moveBefore feature detection#32087
Conversation
`moveBefore` was moved to the `ParentNode` mixin as per whatwg/dom#1307 (comment) (and was committed in whatwg/dom@3f3e94c) As a result, its existence can no longer be checked on `Node.prototype` but must be checked in `Element.prototype`.
|
Hi @bramus! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
|
Comparing: 5b51a2b9e249f264b1345cc35b275464ae3ef6eb...28622b82c320598f437e491eb9e68c8196502dcd Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: Expand to show
|
`moveBefore` was moved to the `ParentNode` mixin as per whatwg/dom#1307 (comment) _(and was committed in whatwg/dom@3f3e94c5beda922962dacaeb606087f57bd7f7be)_ As a result, its existence can no longer be checked on `Node.prototype` but must be checked in `Element.prototype` DiffTrain build for [313c8c5](313c8c5)
4 participants
moveBeforewas moved to theParentNodemixin as per whatwg/dom#1307 (comment) (and was committed in whatwg/dom@3f3e94c)As a result, its existence can no longer be checked on
Node.prototypebut must be checked inElement.prototype