Remove allowConcurrentByDefault flag#30445
Merged
jackpope merged 1 commit intofacebook:mainfrom Jul 25, 2024
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
facebook-github-bot
added
CLA Signed
React Core Team
Collaborator
|
Need to wait for https://github.com/facebook/react/actions/runs/10079081825 to complete or rebase so that sizebot gets a working merge base |
eps1lon
approved these changes
Jul 24, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Jul 25, 2024
Following #30436 Concurrent by default strategy has been unshipped. Here we clean up the `allowConcurrentByDefault` path and related logic/tests. For now, this keeps the `concurrentUpdatesByDefaultOverride` argument in `createContainer` and `createHydrationContainer` and ignores the value to prevent more breaking changes to `react-reconciler` in the RC stage. DiffTrain build for commit 14a4699.
github-actions bot
pushed a commit
that referenced
this pull request
Jul 25, 2024
Following #30436 Concurrent by default strategy has been unshipped. Here we clean up the `allowConcurrentByDefault` path and related logic/tests. For now, this keeps the `concurrentUpdatesByDefaultOverride` argument in `createContainer` and `createHydrationContainer` and ignores the value to prevent more breaking changes to `react-reconciler` in the RC stage. DiffTrain build for [14a4699](14a4699)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following #30436
Concurrent by default strategy has been unshipped. Here we clean up the
allowConcurrentByDefaultpath and related logic/tests.For now, this keeps the
concurrentUpdatesByDefaultOverrideargument increateContainerandcreateHydrationContainerand ignores the value to prevent more breaking changes toreact-reconcilerin the RC stage.