[compiler][ez] Patch Array.concat object shape to capture callee

[mofeiZ]

Stack from ghstack (oldest at bottom):

• [compiler][ez] PrintHIR prints optional flag for debugging #30078
• [compiler][patch] Patch O(n^2) traversal in validatePreserveMemo #30077
• [compiler][hir] Correctly remove non-existent terminal preds when pruning labels #30076
• [compiler][ez] Add more Array.prototype methods #30075
• -> [compiler][ez] Patch Array.concat object shape to capture callee #30074
• [compiler][rewrite] Patch logic for aligning scopes to non-value blocks #29891
• [compiler][fixtures] test repros: codegen, alignScope, phis #29878

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
react-compiler-playground	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jun 25, 2024 8:14pm

[mofeiZ]

This was a pretty rare pattern internally -- we almost ever reference Array.prototype.concat's callee after the concat call. Interior mutability of the callee is even rarer

[react-sizebot]

Comparing: 133ada7...e724d4d

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name	+/-	Base	Current	+/- gzip	Base gzip	Current gzip
oss-stable/react-dom/cjs/react-dom.production.js	=	6.68 kB	6.68 kB	=	1.83 kB	1.83 kB
oss-stable/react-dom/cjs/react-dom-client.production.js	=	497.93 kB	497.93 kB	=	89.26 kB	89.26 kB
oss-experimental/react-dom/cjs/react-dom.production.js	=	6.69 kB	6.69 kB	=	1.83 kB	1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js	=	502.75 kB	502.75 kB	=	89.96 kB	89.96 kB
facebook-www/ReactDOM-prod.classic.js	=	597.10 kB	597.10 kB	=	105.31 kB	105.31 kB
facebook-www/ReactDOM-prod.modern.js	=	571.44 kB	571.44 kB	=	101.24 kB	101.24 kB
test_utils/ReactAllWarnings.js	Deleted	62.88 kB	0.00 kB	Deleted	15.69 kB	0.00 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show

Name	+/-	Base	Current	+/- gzip	Base gzip	Current gzip
test_utils/ReactAllWarnings.js	Deleted	62.88 kB	0.00 kB	Deleted	15.69 kB	0.00 kB

Generated by 🚫 dangerJS against e724d4d

[josephsavona]

nice

[josephsavona]

I really want to redo our effects system, the current groupings are imprecise since it captures the content but not the array itself. But the tests cases look good so this is fine, just an aside.