Sync from oss-experimental, not oss-stable#26401
Merged
rickhanlonii merged 2 commits intofacebook:mainfrom Mar 16, 2023
Merged
Conversation
facebook-github-bot
added
CLA Signed
React Core Team
josephsavona
approved these changes
Mar 15, 2023
|
Comparing: 47cf4e5...58ef82f Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: (No significant changes) |
gaearon
reviewed
Mar 15, 2023
| function isUseEffectEventIdentifier(node) { | ||
| if (__EXPERIMENTAL__) { | ||
| return node.type === 'Identifier' && node.name === 'useEffectEvent'; | ||
| return node.type === 'Identifier' && (node.name === 'useEffectEvent' || node.name === 'experimental_useEffectEvent') ; |
Collaborator
There was a problem hiding this comment.
I don't think this makes sense. It wouldn't be caught by Rules of Hooks etc anyway. I think what we'd want to do is re-export it internally without the prefix when trying it.
gaearon
approved these changes
Mar 15, 2023
Collaborator
gaearon
left a comment
gaearon
left a comment
There was a problem hiding this comment.
If you can get the CI green, sounds fine, but I think we need to revert the suffix change. We'll instead re-export it under a use* name or we'll alias it at the import site.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
To test useEffectEvent, we need the experimental build of the lint plugin.