Use NoLanes to replace zero for consistency#24326
Closed
wtlin1228 wants to merge 1 commit intofacebook:mainfrom
Closed
Use NoLanes to replace zero for consistency#24326wtlin1228 wants to merge 1 commit intofacebook:mainfrom
NoLanes to replace zero for consistency#24326wtlin1228 wants to merge 1 commit intofacebook:mainfrom
Conversation
Collaborator
|
I've noticed you're sending many PRs with small cleanups. They're appreciated but let's put it all in a single PR? Since each is trivial and we'd like not to pollute the commit history with too many cosmetic changes. |
|
Comparing: e0160d5...a398457 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: (No significant changes) |
Contributor
Author
|
Close as duplicate #24327 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Use
NoLanesto replace zero for consistency with the surrounding code.How did you test this change?
This PR shouldn't break anything since
NoLanesis equal to0.