Revert "Revert "Use act() in ReactFabric tests""#21843
Revert "Revert "Use act() in ReactFabric tests""#21843sujatakhadka111 wants to merge 1 commit intofacebook:mainfrom
act() in ReactFabric tests""#21843Conversation
…acebook#21840)" This reverts commit c549bc4.
|
Hi @sujatakhadka111! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
|
Comparing: 84639ab...2b7cbb9 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: (No significant changes) |
|
@sujatakhadka111 What's the plan with this PR? Some explanation is generally required for any PR, include reverts. cc @yungsters |
|
@acdlite already re-landed these changes using |
|
So this PR can be closed? |
|
I think so… |
|
Okay. Closing for now then unless I hear otherwise from @sujatakhadka111. |
Reverts #21840