[Fizz] Allow dangerouslySetInnerHTML in <option>#21373
Merged
sebmarkbage merged 1 commit intofacebook:masterfrom May 4, 2021
Merged
[Fizz] Allow dangerouslySetInnerHTML in <option>#21373sebmarkbage merged 1 commit intofacebook:masterfrom
sebmarkbage merged 1 commit intofacebook:masterfrom
Conversation
facebook-github-bot
added
React Core Team
|
Comparing: 9a25916...03ad985 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: Expand to show
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I didn't think this was valid because if you don't provide a
valuefor the option, we don't know whether to select it or not. However it's arguably valid if you do provide the value attribute.We should probably have a warning if you provide dangerouslySetInnerHTML and don't provide a value attribute though. Both server and client.