Conversation
facebook-github-bot
added
CLA Signed
React Core Team
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 8a385e4:
|
| "name": "eslint-plugin-react-hooks", | ||
| "description": "ESLint rules for React Hooks", | ||
| "version": "4.1.2", | ||
| "version": "4.2.0", |
There was a problem hiding this comment.
What was the point of this eslint-plugin-react-hooks minor version bump, it appears there are no changes? Also, this new version was published without a changelog entry:
https://github.com/facebook/react/blob/master/packages/eslint-plugin-react-hooks/CHANGELOG.md
There was a problem hiding this comment.
No particular reason other than our release script releases all packages.
There was a problem hiding this comment.
Such a script is undesirable. Millions of developers are needlessly updating a "outdated" dependency, looking around for a changelog entry (that doesn't exist) to explain the new semver minor features (that also don't exist).
There was a problem hiding this comment.
I added the changelog entry. Your opinion is noted. This was a stressful release that took us many months, and I overlooked this detail. I'm sorry to hear you were frustrated by it.
5 participants
Just re-doing the same our script did on build + bumps a few more that are private but stale.
I changed
peerDepsfor React and ReactDOM to use an exact version of React. Kept it a caret in other places.