Add feature flag around React.createFactory#17873
Merged
trueadm merged 1 commit intofacebook:masterfrom Jan 20, 2020
Merged
Conversation
trueadm
requested review from
acdlite,
bvaughn,
gaearon,
necolas and
sebmarkbage
facebook-github-bot
added
CLA Signed
React Core Team
threepointone
approved these changes
Jan 20, 2020
Contributor
threepointone
left a comment
threepointone
left a comment
There was a problem hiding this comment.
codesandbox CI build failing? looks like a transient error.
Add comment to re-trigger build
trueadm
force-pushed
the
create-factory-flag
branch
from
b8ce161 to
4314afa
Compare
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 4314afa:
|
Contributor
|
Before we actually remove this, we’ll need to run a warning for a while. Should we also have a flag to add the warning? |
Contributor
Author
|
I thought we’d most likely just add the warning without a flag. I’ve removed all internal www usages, so this would mostly be OSS only. |
Contributor
|
We should add the warning now then. I'm scared we'll forget it if we leave it. |
Contributor
Author
|
Agreed @sebmarkbage. PR is up for review: #17878 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a
disableCreateFactoryfeature flag that allows us to disableReact.createFactoryfrom being exported from the React package. I also had to update all tests that made use of this API and move them toReact.createElement.