Remove scheduler from React package dependencies#15616
Merged
acdlite merged 1 commit intofacebook:masterfrom May 10, 2019
Merged
Remove scheduler from React package dependencies#15616acdlite merged 1 commit intofacebook:masterfrom
acdlite merged 1 commit intofacebook:masterfrom
Conversation
Scheduler is used by the renderers, but not the isomorphic package.
bvaughn
approved these changes
May 10, 2019
Contributor
bvaughn
left a comment
bvaughn
left a comment
There was a problem hiding this comment.
Hm... I'm not sure now why this was added. At first I thought it was required by our Rollup config but I guess that's not the case because scheduler is one of our known globals.
Maybe this was meant to signal the fact that the dependency exists, conceptually? I don't know.
Details of bundled changes.Comparing: 90f54d7...b1b96f2 react
Generated by 🚫 dangerJS |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scheduler is used by the renderers, but not the isomorphic package.
I checked the history to figure out why it was originally added as a dep. It looks like it was because the UMD build of
reactincludes Scheduler inline instead of treating it as an external: #13509We may need to reconsider our UMD strategy later once the public Scheduler API is stable. (Personally I would prefer to drop UMD support entirely.)
Regardless we can remove it from
package.json. I confirmed that the UMD bundle still includes Scheduler.