Warning message no longer recommends using deprecated lifecycle method.

[iliran11]

Fixing the folllwing issue: #12748;

1. componentWillMount is soon to be deprecated method, so recommending to use it, is not a viable options.

2. Author of the warning message has warned against constructor side-effects. as per the official react docs, the right way to do it, is placing those side effects in componentDidMount.

Avoid introducing any side-effects or subscriptions in the constructor. For those use cases, use componentDidMount() instead.

[gaearon]

I'd prefer a warning that's a bit more detailed. "Either assign the initial state in constructor, or move the setState call to componentDidMount."

[gaearon]

See above

[iliran11]

@gaearon I have updated the warning message. please take a lot.
sorry for the delay by the way :)

[gaearon]

Please run yarn prettier and commit

[gaearon]

Can we add "(such as within render...)" part back? I don't see why it needs to be changed.

[iliran11]

was just thinking it was lengthy.
maybe perhaps instead of printing "Cannot update during an existing state transition" , It is better to be concise and print "Cannot update state during render lifecycle method" ?

[gaearon]

Looking at this again, I don't see why the message assumes we're in the constructor. This code is for setState in render, isn't it?

[iliran11]

@gaearon why the message assumes we are in the constructor? right now it suggests to initially set the state in the constructor, or use setState on componentDidMount , instead of using setState in render (so it assumes we are in render method)

[iliran11]

was just thinking it was lengthy.
maybe perhaps instead of printing "Cannot update during an existing state transition" , It is better to be concise and print "Cannot update state during render lifecycle method" ?

[iliran11]

I can't really understand why CircleCi is failing on Test Packages job.
it writes in the job output:

Test Suites: 149 passed, 149 total
Tests: 26 skipped, 3043 passed, 3069 total
Snapshots: 40 passed, 40 total
Time: 128.754s
Ran all test suites.
Done in 130.43s.

[aweary]

@iliran11 you need to run yarn prettier

[iliran11]

@aweary @gaearon OK, the CI has passed finally. yarn prettier didn't do the trick. it made no changes to files. git status returned nothing to commit.

in the end i used prettier plugin in visual code to solve this and just formatted the files I edited.

[luyaor]

Hi Liran Cohen(@iliran11),
We are researchers working on identifying redundant development and duplicated pull requests. We would like to help open source community to reduce redundant work. We have found there is another open pull request: #13169 which might be a potentially duplicate to this one. We would really appreciate if you could help us to validate and give us feedback.

@gaearon Sorry again if it creates notification noise on the repository.

[gaearon]

Sorry for the churn. I ended up merging #13169 because it was more accurate: as it turned out, this code path doesn't actually run for the constructor anymore. So mentioning constructor didn't make sense. Thanks for the effort though!