Fix launching text editor from a redbox stacktrace on windows

[janicduplessis]

Launch the editor with cmd on windows.

[facebook-github-bot]

By analyzing the blame information on this pull request, we identified @frantic, @pcottle and @sahrens to be potential reviewers.

[pcottle]

I'm worried the args.unshift will be brittle if someone else changes the implementation above.

maybe we should just fork on win32 earlier? we already have getArgumentsForLineNumber(editor, fileName, lineNumber) abstracted out. id just like to see something like:

args = [
  editor,
  '\c', // explanation why this is
  fileName,
  lineNumber ? getArgumentsForLineNumber(editor, fileName, lineNumber) : '',
];

[janicduplessis]

@pcottle The goal here is just to launch the editor in a shell because Windows can only run .exe files with child_process.spawn and atom for example, uses a .cmd file. I think forking at child_process.spawn is fine but you are right, using unshift isn't a good idea because it will modify the args object if we ever change something after it could break.

There is an open pull request in node at the moment to add a shell option to spawn that could be better to use eventually. nodejs/node#4598

[facebook-github-bot]

@janicduplessis updated the pull request.

[facebook-github-bot]

@janicduplessis updated the pull request.

[pcottle]

Great! A ton cleaner. will import

[pcottle]

@facebook-github-bot shipit

[facebook-github-bot]

Thanks for importing. If you are an FB employee go to https://our.intern.facebook.com/intern/opensource/github/pull_request/797876773651420/int_phab to review.