Prepare typing changes for HostComponent#47150
Closed
SamChou19815 wants to merge 1 commit intofacebook:mainfrom
SamChou19815:export-D64722939
Closed
Prepare typing changes for HostComponent#47150SamChou19815 wants to merge 1 commit intofacebook:mainfrom SamChou19815:export-D64722939
SamChou19815 wants to merge 1 commit intofacebook:mainfrom
SamChou19815:export-D64722939
Conversation
Summary: In facebook/react#31314, I will change the host component type that will be synced to react-native. Notably, it will expose the issue where all the `HostComponent<mixed>` types are wrong, since it doesn't make sense to write `React.AbstractComponent<mixed>`. This diff fixes the existing usages first in prep for that typing change. Changelog: [Internal] Differential Revision: D64722939
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D64722939 |
Contributor
|
This pull request has been merged in 71e9039. |
Collaborator
|
This pull request was successfully merged by @SamChou19815 in 71e9039 When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
In facebook/react#31314, I will change the host component type that will be synced to react-native. Notably, it will expose the issue where all the
HostComponent<mixed>types are wrong, since it doesn't make sense to writeReact.AbstractComponent<mixed>. This diff fixes the existing usages first in prep for that typing change.Changelog: [Internal]
Differential Revision: D64722939