Merged
Conversation
crbelaus
force-pushed
the
ignore-errors
branch
from
47a1b91 to
bd34eb0
Compare
odarriba
requested changes
Sep 5, 2024
Contributor
odarriba
left a comment
odarriba
left a comment
There was a problem hiding this comment.
We need to rework the condition in which the error is stored, as by default without ignorer configured they are not stored.
Also, as the last commit was a docs one, the CI didn't run but some tests should fail as it is now as errors are not stored.
crbelaus
pushed a commit
that referenced
this pull request
Sep 8, 2024
This change adds a new global flag named `:enabled` that allows to disable the error tracking on certain environments. This behaviour can be done also with a custom ignorer using the changes that we will introduce in #79 , but I felt like this use case will be quite common in dev environments and having a fast way to just disable every error is useful. Test have been added and documentation updated. Closes #81
crbelaus
force-pushed
the
ignore-errors
branch
from
e51959a to
f671cc6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds the new
ErrorTracker.Ignorerbehaviour that can be used by clients to ignore errors based on their attributes and context.I've added a test to verify that it works as expected and also updated the docs and getting started guide.