Conversation
Contributor
Author
|
Early review before doing docs and so on is appreciated @crbelaus can you take a look? 👀 |
crbelaus
reviewed
Nov 13, 2024
Contributor
|
I've pushed a small commit that adds a |
Contributor
Author
|
Ready to review again @crbelaus 🙌 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds support for breadcrumbs as a first-class field on our occurrences.
Breadcrumbs are now a way to store a list of strings indicating in which order they were added, so they can be used to track which code was executed and on which order. They are managed per-process (which in Phoenix means per-request in general)
AshandSplodewas updated to match the new system