-
Notifications
You must be signed in to change notification settings - Fork 525
github: add support for additional audit log fields #7976
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
* actor_ip * hashed_token * integration * programmatic_access_type * repositories_added_names * repositories_removed_names * repository_selection * user_agent
🌐 Coverage report
|
|
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
added descriptions for additional fields
Added field descriptions for new fields
nit edit
| ignore_missing: true | ||
| - rename: | ||
| field: json.user_agent | ||
| target_field: github.user_agent |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could be interesting to convert this field into an ECS field using the user_agent processor?
| ignore_missing: true | ||
| - convert: | ||
| field: json.actor_ip | ||
| target_field: github.actor_ip |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could populate related_ip with this field.
chemamartinez
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
|
Package github - 1.24.0 containing this change is available at https://epr.elastic.co/search?package=github |
What does this PR do?
Add under
github:actor_iphashed_tokenintegrationprogrammatic_access_typerepositories_added_namesrepositories_removed_namesrepository_selectionuser_agentChecklist
changelog.ymlfile.Author's Checklist
How to test this PR locally
Related issues
Screenshots