Skip to content

Conversation

@legoguy1000
Copy link
Contributor

@legoguy1000 legoguy1000 commented Sep 27, 2021

What does this PR do?

Adds integration to fetch GitHub audit logs

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • If I'm introducing a new feature, I have modified the Kibana version constraint in my package's manifest.yml file to point to the latest Elastic stack release (e.g. ^7.13.0).

Author's Checklist

  • [ ]

How to test this PR locally

cd integrations/packages/github
elastic-package build && elastic-package stack down && elastic-package stack up  --version 7.16.0-SNAPSHOT  -d -v && eval "$(elastic-package stack shellinit)" && elastic-package test -v

Related issues

Screenshots

github-user

github-audit

@elasticmachine
Copy link

elasticmachine commented Sep 27, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-10-12T20:52:09.084+0000

  • Duration: 13 min 8 sec

  • Commit: da78bce

Test stats 🧪

Test Results
Failed 0
Passed 20
Skipped 0
Total 20

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@legoguy1000 legoguy1000 marked this pull request as ready for review September 29, 2021 23:39
@P1llus
Copy link
Member

P1llus commented Sep 30, 2021

/test

@P1llus
Copy link
Member

P1llus commented Sep 30, 2021

/test

@P1llus
Copy link
Member

P1llus commented Sep 30, 2021

Just going to see if we can test this against our own Github Account, but the rest looks good!

@legoguy1000
Copy link
Contributor Author

Just going to see if we can test this against our own Github Account, but the rest looks good!

Sweet. You'll need someone with org:admin role.

@P1llus
Copy link
Member

P1llus commented Oct 12, 2021

/test

Copy link
Member

@P1llus P1llus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great! tested on our API as well, LGTM!

@P1llus P1llus merged commit 7882ca4 into elastic:master Oct 13, 2021
@andrewkroh andrewkroh added Integration:github GitHub New Integration Issue or pull request for creating a new integration package. labels Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Integration:github GitHub New Integration Issue or pull request for creating a new integration package.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants