-
Notifications
You must be signed in to change notification settings - Fork 525
kubernetes#container_logs: update docs for GZIP promoted to GA on 9.3 #16581
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
9127a9c to
cbf67d4
Compare
🚀 Benchmarks reportPackage
|
| Data stream | Previous EPS | New EPS | Diff (%) | Result |
|---|---|---|---|---|
container_logs |
250000 | 200000 | -50000 (-20%) | 💔 |
To see the full report comment with /test benchmark fullreport
35090a2 to
0b3b9b5
Compare
Update the container logs docs on ingesting rotated logs, including GZIP-compressed logs, with the new `compression` configuration, for 9.3+, and mark `gzip_experimental` as for 9.2.x.
0b3b9b5 to
b7a00d8
Compare
|
Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane) |
|
cc @bturquet |
|
@gizas can you hep with reviewing the PR please ? |
| name: kubernetes | ||
| title: Kubernetes | ||
| version: 1.82.1 | ||
| version: 1.83.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wondering if version: "^8.15.0 || ^9.3.0" and update the above values as per comment https://github.com/elastic/integrations/pull/16581/files#r2627363467
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We haven't done that for filestream. The idea is the integration still works with older versions and making it would basically start to bound a integration version to a specific release. It'd make difficult to add changes that are backwards compatible.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed. Then you should have marked it as Breaking change in this case. So users to be aware that something might break in case of upgrade.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there is no breaking change. If they upgrade nothing will happen. It's just updating the docs guiding them if they want to ingest rotated logs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NW I had in mid that you would have changed the default configuration and pin a specific version to be availalble. But now is clear
💚 Build Succeeded
History
cc @AndersonQ |
|
Package kubernetes - 1.83.0 containing this change is available at https://epr.elastic.co/package/kubernetes/1.83.0/ |
Proposed commit message
Checklist
[ ] I have reviewed tips for building integrations and this pull request is aligned with them.changelog.ymlfile.[ ] I have verified that Kibana version constraints are current according to guidelines.Author's Checklist
How to test this PR locally
flog.yaml:
cd packages/kubernetes elastic-package build -v elastic-package install -vcurl -O -L https://snapshots.elastic.co/9.3.0-40d73df7/downloads/beats/elastic-agent/elastic-agent-9.3.0-SNAPSHOT-linux-x86_64.tar.gztar -xf elastic-agent-9.3.0-SNAPSHOT-linux-x86_64.tar.gzInvalidImageName, check here to see hot to fix itlog.file.path : *flog*. Ensure the logs come from/var/log/pods/and there are files with.log.gzextensionRelated issues
compressionconfig #16221## Screenshots