-
Notifications
You must be signed in to change notification settings - Fork 527
azure: add Grok processor for AzureFirewallThreatIntelLog #13921
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Pinging @elastic/security-service-integrations (Team:Security-Service Integrations) |
| - "^%{DATA:azure.firewall.proto} request from %{IPORHOST:source.address}:%{NUMBER:source.port:long} to %{IPORHOST:destination.address}:%{NUMBER:destination.port:long}. Url: %{HOSTNAME:url.original}. Action: %{DATA:azure.firewall.action}. ThreatIntel: %{DATA:rule.name}$" | ||
| if: ctx?.json?.operationName == 'AzureFirewallNetworkRuleLog' || ctx?.json?.operationName == 'AzureFirewallNatRuleLog' | ||
|
|
||
| - grok: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a test that covers this case.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Run pipeline tests for the package
--- Test results for package: azure - START ---
╭─────────┬───────────────┬───────────┬─────────────────────────────────────────────────────────────────────┬────────┬──────────────╮
│ PACKAGE │ DATA STREAM │ TEST TYPE │ TEST NAME │ RESULT │ TIME ELAPSED │
├─────────┼───────────────┼───────────┼─────────────────────────────────────────────────────────────────────┼────────┼──────────────┤
│ azure │ firewall_logs │ pipeline │ (ingest pipeline warnings test-applicationrules-raw.log) │ PASS │ 330.67625ms │
│ azure │ firewall_logs │ pipeline │ (ingest pipeline warnings test-applicationrules-structured-raw.log) │ PASS │ 294.189208ms │
│ azure │ firewall_logs │ pipeline │ (ingest pipeline warnings test-dnsproxy-structured-raw.log) │ PASS │ 289.398917ms │
│ azure │ firewall_logs │ pipeline │ (ingest pipeline warnings test-dnsproxyrules-raw.log) │ PASS │ 321.9885ms │
│ azure │ firewall_logs │ pipeline │ (ingest pipeline warnings test-natrule-structured-raw.log) │ PASS │ 286.860292ms │
│ azure │ firewall_logs │ pipeline │ (ingest pipeline warnings test-networkrule-structured-raw.log) │ PASS │ 312.447292ms │
│ azure │ firewall_logs │ pipeline │ (ingest pipeline warnings test-networkrules-raw.log) │ PASS │ 294.68775ms │
│ azure │ firewall_logs │ pipeline │ (ingest pipeline warnings test-sdh3075-raw.log) │ PASS │ 301.59275ms │
│ azure │ firewall_logs │ pipeline │ (ingest pipeline warnings test-threatintel-raw.log) │ PASS │ 297.325167ms │
│ azure │ firewall_logs │ pipeline │ test-applicationrules-raw.log │ PASS │ 127.56975ms │
│ azure │ firewall_logs │ pipeline │ test-applicationrules-structured-raw.log │ PASS │ 76.394ms │
│ azure │ firewall_logs │ pipeline │ test-dnsproxy-structured-raw.log │ PASS │ 66.39725ms │
│ azure │ firewall_logs │ pipeline │ test-dnsproxyrules-raw.log │ PASS │ 81.463458ms │
│ azure │ firewall_logs │ pipeline │ test-natrule-structured-raw.log │ PASS │ 70.352875ms │
│ azure │ firewall_logs │ pipeline │ test-networkrule-structured-raw.log │ PASS │ 69.035166ms │
│ azure │ firewall_logs │ pipeline │ test-networkrules-raw.log │ PASS │ 162.922875ms │
│ azure │ firewall_logs │ pipeline │ test-sdh3075-raw.log │ PASS │ 69.803208ms │
│ azure │ firewall_logs │ pipeline │ test-threatintel-raw.log │ PASS │ 61.601166ms │
╰─────────┴───────────────┴───────────┴─────────────────────────────────────────────────────────────────────┴────────┴──────────────╯
--- Test results for package: azure - END ---
Done
Co-authored-by: Dan Kortschak <dan.kortschak@elastic.co>
|
/test |
🚀 Benchmarks reportPackage
|
| Data stream | Previous EPS | New EPS | Diff (%) | Result |
|---|---|---|---|---|
signinlogs |
2272.73 | 1841.62 | -431.11 (-18.97%) | 💔 |
auditlogs |
2188.18 | 1769.91 | -418.27 (-19.11%) | 💔 |
eventhub |
500000 | 333333.33 | -166666.67 (-33.33%) | 💔 |
To see the full report comment with /test benchmark fullreport
packages/azure/data_stream/firewall_logs/elasticsearch/ingest_pipeline/default.yml
Outdated
Show resolved
Hide resolved
packages/azure/data_stream/firewall_logs/_dev/test/pipeline/test-threatintel-raw.log
Outdated
Show resolved
Hide resolved
zmoog
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see the PR is security-focused.
Approving on behalf of the elastic/obs-ds-hosted-services team based on co-ownership of packages/azure/(changelog|manifest).yml and packages/azure/docs/.
efd6
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Marking request changes to prevent accidental merge without addressing the comments from my previous review.
…pipeline/default.yml Co-authored-by: Dan Kortschak <dan.kortschak@elastic.co>
| @@ -1,3 +1,8 @@ | |||
| - version: "1.25.0" | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs to be reflected in the manifest in the version field as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed by 801882b
| @@ -0,0 +1 @@ | |||
| {"category":"AzureFirewallNetworkRule","operationName":"AzureFirewallThreatIntelLog","properties":{"msg":"TCP request from 192.168.0.2:49680 to 89.160.20.156:1688. Action: Deny. ThreatIntel: Destination reported by Threat Intelligence"},"resourceId":"/SUBSCRIPTIONS/23103928-B2CF-472A-8CDB-0146E2849129/RESOURCEGROUPS/TEST-FW-RG/PROVIDERS/MICROSOFT.NETWORK/AZUREFIREWALLS/TEST-FW01","time":"2025-05-16T07:34:42.525499+00:00"} No newline at end of file | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a final new line.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed by 801882b
|
/test |
|
💚 Build Succeeded
History
|
efd6
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
|
Package azure - 1.25.0 containing this change is available at https://epr.elastic.co/package/azure/1.25.0/ |




Proposed commit message
Checklist
changelog.ymlfile.Author's Checklist
How to test this PR locally
Related issues
Screenshots