fix(packages/falco): use ecs definition for process.group.{id,name} #13589
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Falco was using data type 'text' for the process.group.id and process.group.name fields, but those fields are defined as 'keyword' in ECS leading to conflicts with other packages that are following ECS. I modified the field definitions to use 'external: ecs' where possible. And removed unused attributes from fields.yml files.
🚀 Benchmarks reportTo see the full report comment with |
andrewkroh
added
Integration:falco
|
Pinging @elastic/security-service-integrations (Team:Security-Service Integrations) |
ShourieG
reviewed
Apr 22, 2025
| description: Preserved Falco field | ||
| external: ecs | ||
| - name: event.dataset | ||
| type: constant_keyword |
Contributor
There was a problem hiding this comment.
Any specific reason we are not removing type: constant_keyword here, since we are already referencing ecs ?
ShourieG
reviewed
Apr 22, 2025
| external: ecs | ||
| value: falco.alerts | ||
| - name: event.module | ||
| type: constant_keyword |
5 tasks
andrewkroh
commented
Apr 24, 2025
|
💚 Build Succeeded
History
|
|
Package falco - 1.3.1 containing this change is available at https://epr.elastic.co/package/falco/1.3.1/ |
efd6
added a commit
to efd6/integrations
that referenced
this pull request
Jul 15, 2025
This essentially replays the field definitions changes in elastic#13589 and elastic#13589 but for the alerts_agent data stream.
efd6
added a commit
to efd6/integrations
that referenced
this pull request
Jul 15, 2025
This essentially replays the field definitions changes in elastic#13589 and elastic#13589 but for the alerts_agent data stream.
efd6
added a commit
that referenced
this pull request
Jul 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed commit message
Falco was using data type 'text' for the process.group.id and
process.group.name fields, but those fields are defined as 'keyword' in
ECS leading to conflicts with other packages that are following ECS.
I modified the field definitions to use 'external: ecs' where possible.
And removed unused attributes from fields.yml files.
Checklist
changelog.ymlfile.Author's Checklist
How to test this PR locally
Related issues
Screenshots