Global search navigation N&N entry#508
Conversation
There was a problem hiding this comment.
Pull request overview
Adds a New & Noteworthy entry to the Eclipse Platform 4.40 release notes describing the new global search result navigation shortcuts introduced for the Global Search Navigation feature.
Changes:
- Adds a “Global Search Navigation” section to the 4.40 Platform release notes.
- Documents new global navigation keybindings and includes an illustrative GIF.
- Includes contributor attribution in the standard
<details>block format.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| This feature implements global search navigation commands `Alt+,` and `Alt+.` (`Cmd+Opt+,` and `Cmd+Opt+.` on macOS) to navigate to previous/next search results even when search view is out of focus, hopefully allowing for easier and more intuitive navigation for users. | ||
|
|
||
|
|
||
|  |
There was a problem hiding this comment.
The image link uses a Windows-style backslash in the relative path (images\...), which won’t resolve correctly in Markdown/GitHub rendering. Use a forward slash path relative to this file (e.g., images/...).
|  | |
|  |
|
|
||
|  | ||
|
|
||
| As shown by the gif, using the global search navigation commands can allow you to navigate to previous/next entries even when another view or editor is in focus No newline at end of file |
There was a problem hiding this comment.
Minor grammar/punctuation: consider capitalizing “GIF” and adding a trailing period to the sentence so the release note reads cleanly.
| As shown by the gif, using the global search navigation commands can allow you to navigate to previous/next entries even when another view or editor is in focus | |
| As shown by the GIF, using the global search navigation commands can allow you to navigate to previous/next entries even when another view or editor is in focus. |
merks
left a comment
merks
left a comment
There was a problem hiding this comment.
Please squash the changes to a single commit, i.e., use amend when commiting changes during the review.
|
|
||
|  | ||
|
|
||
| The GIF demostrates navigation using the new commands despite the user switching out of the Search view No newline at end of file |
There was a problem hiding this comment.
Please end the sentenced with a period.
| - [Shubham Waldiya](https://github.com/ShuWald) | ||
| </details> | ||
|
|
||
| The current search navigation commands `Ctrl+,` and `Ctrl+.` allow for navigation to the previous or next search result, respectively. However, one limitation is that these shortcuts only work when the search view is in focus. |
There was a problem hiding this comment.
Please split sentences onto separate lines.
| </details> | ||
|
|
||
| The current search navigation commands `Ctrl+,` and `Ctrl+.` allow for navigation to the previous or next search result, respectively. However, one limitation is that these shortcuts only work when the search view is in focus. | ||
| This feature implements global search navigation commands `Alt+,` and `Alt+.` (`Cmd+Opt+,` and `Cmd+Opt+.` on macOS) to navigate to previous/next search results even when search view is out of focus, hopefully allowing for easier and more intuitive navigation for users. |
There was a problem hiding this comment.
I'd remove the word hopefully and the words for users because we should not suggest we aren't sure it's easier and more intuitive and of course it's for users, who else?
ShuWald
force-pushed
the
fix/global-search-nav-entry
branch
2 times, most recently
from
61b8c9e to
4c6cd71
Compare
|
Thank you for your feedback, I have made all the suggested changes. Let me know if anything else needs to be fixed! |
merks
left a comment
merks
left a comment
There was a problem hiding this comment.
Just one small typo I should have noticed earlier. Sorry.
|
|
||
|  | ||
|
|
||
| The GIF demostrates navigation using the new commands despite the user switching out of the Search view. |
There was a problem hiding this comment.
| The GIF demostrates navigation using the new commands despite the user switching out of the Search view. | |
| The GIF demonstrates navigation using the new commands despite the user switching out of the Search view. |
ShuWald
force-pushed
the
fix/global-search-nav-entry
branch
from
4c6cd71 to
5e5e15c
Compare
|
Thanks for catching that, I apologize for my oversight. I have double-checked the rest of my entry for any spelling issues as well. Let me know if any other changes need to be made. Thanks |
merks
left a comment
merks
left a comment
There was a problem hiding this comment.
Thanks for the cool feature and for writing a news entry too!
Adds New & Noteworthy entry for Global Search Navigation feature for Eclipse, which resolves the following: Feature Request: Global “Next Search Result” Navigation in Eclipse #3240
PR Link: feat : Add global search result navigation shortcuts #3299
Let me know if there are any issues with my entry and I will fix them!