Skip to content

Remove ImageContent and AudioContent#5814

Merged
MackinnonBuck merged 9 commits intomainfrom
mbuck/datacontent-fixes
Jan 29, 2025
Merged

Remove ImageContent and AudioContent#5814
MackinnonBuck merged 9 commits intomainfrom
mbuck/datacontent-fixes

Conversation

@MackinnonBuck
Copy link
Copy Markdown
Member

@MackinnonBuck MackinnonBuck commented Jan 24, 2025 •
edited by dotnet-policy-service Bot
Loading

Removes the ImageContent and AudioContent types.

The recommendation will be that chat client implementors and app developers use DataContent.MediaType to distinguish between the various content types.

Fixes #5719

Microsoft Reviewers: Open in CodeFlow

@MackinnonBuck MackinnonBuck requested review from a team as code owners January 24, 2025 22:20
@dotnet-comment-bot
Copy link
Copy Markdown
Collaborator

dotnet-comment-bot commented Jan 25, 2025

‼️ Found issues ‼️

Project Coverage Type Expected Actual
Microsoft.Extensions.Caching.Hybrid Line 86 84.76 🔻

🎉 Good job! The coverage increased 🎉
Update MinCodeCoverage in the project files.

Project Expected Actual
Microsoft.Extensions.AI 88 89

Full code coverage report: https://dev.azure.com/dnceng-public/public/_build/results?buildId=928961&view=codecoverage-tab

stephentoub
stephentoub reviewed Jan 27, 2025
View reviewed changes
Comment thread src/Libraries/Microsoft.Extensions.AI.AzureAIInference/AzureAIInferenceChatClient.cs Outdated
Comment thread src/Shared/AIExtensions/DataContentMediaTypeExtensions.cs Outdated
Comment thread src/Libraries/Microsoft.Extensions.AI.Ollama/OllamaChatClient.cs Outdated
Comment thread ...rosoft.Extensions.AI.Abstractions.Tests/ChatCompletion/StreamingChatCompletionUpdateTests.cs Outdated
@MackinnonBuck MackinnonBuck force-pushed the mbuck/datacontent-fixes branch from 0f6f67f to aaac94f Compare January 28, 2025 00:50
@MackinnonBuck MackinnonBuck force-pushed the mbuck/datacontent-fixes branch from aaac94f to b7bb5b9 Compare January 28, 2025 00:53
@dotnet-comment-bot
Copy link
Copy Markdown
Collaborator

dotnet-comment-bot commented Jan 28, 2025

‼️ Found issues ‼️

Project Coverage Type Expected Actual
Microsoft.Gen.MetadataExtractor Line 98 57.35 🔻
Microsoft.Gen.MetadataExtractor Branch 98 62.5 🔻

🎉 Good job! The coverage increased 🎉
Update MinCodeCoverage in the project files.

Project Expected Actual
Microsoft.Extensions.AI.OpenAI 77 78
Microsoft.Extensions.AI.Abstractions 83 84
Microsoft.Extensions.AI 88 89

Full code coverage report: https://dev.azure.com/dnceng-public/public/_build/results?buildId=931303&view=codecoverage-tab

@dotnet-comment-bot
Copy link
Copy Markdown
Collaborator

dotnet-comment-bot commented Jan 28, 2025

‼️ Found issues ‼️

Project Coverage Type Expected Actual
Microsoft.Gen.MetadataExtractor Line 98 57.35 🔻
Microsoft.Gen.MetadataExtractor Branch 98 62.5 🔻

🎉 Good job! The coverage increased 🎉
Update MinCodeCoverage in the project files.

Project Expected Actual
Microsoft.Extensions.AI.OpenAI 77 78
Microsoft.Extensions.AI.Abstractions 83 84
Microsoft.Extensions.AI 88 89

Full code coverage report: https://dev.azure.com/dnceng-public/public/_build/results?buildId=932146&view=codecoverage-tab

@dotnet-comment-bot
Copy link
Copy Markdown
Collaborator

dotnet-comment-bot commented Jan 28, 2025

‼️ Found issues ‼️

Project Coverage Type Expected Actual
Microsoft.Extensions.Caching.Hybrid Line 86 77.7 🔻
Microsoft.Extensions.AI.Ollama Line 80 78.25 🔻
Microsoft.Gen.MetadataExtractor Line 98 57.35 🔻
Microsoft.Gen.MetadataExtractor Branch 98 62.5 🔻

🎉 Good job! The coverage increased 🎉
Update MinCodeCoverage in the project files.

Project Expected Actual
Microsoft.Extensions.AI 88 89
Microsoft.Extensions.AI.Abstractions 83 84
Microsoft.Extensions.AI.OpenAI 77 78

Full code coverage report: https://dev.azure.com/dnceng-public/public/_build/results?buildId=932449&view=codecoverage-tab

stephentoub
stephentoub reviewed Jan 29, 2025
View reviewed changes
Comment thread src/Libraries/Microsoft.Extensions.AI.Abstractions/Contents/DataContent.cs Outdated
stephentoub
stephentoub reviewed Jan 29, 2025
View reviewed changes
Comment thread src/Libraries/Microsoft.Extensions.AI.AzureAIInference/AzureAIInferenceChatClient.cs Outdated
@dotnet-comment-bot
Copy link
Copy Markdown
Collaborator

dotnet-comment-bot commented Jan 29, 2025

‼️ Found issues ‼️

Project Coverage Type Expected Actual
Microsoft.Extensions.AI.Ollama Line 80 78.25 🔻
Microsoft.Gen.MetadataExtractor Line 98 57.35 🔻
Microsoft.Gen.MetadataExtractor Branch 98 62.5 🔻

🎉 Good job! The coverage increased 🎉
Update MinCodeCoverage in the project files.

Project Expected Actual
Microsoft.Extensions.AI.OpenAI 77 78
Microsoft.Extensions.AI.Abstractions 83 84
Microsoft.Extensions.AI 88 89

Full code coverage report: https://dev.azure.com/dnceng-public/public/_build/results?buildId=933933&view=codecoverage-tab

@MackinnonBuck MackinnonBuck merged commit acc985a into main Jan 29, 2025
@MackinnonBuck MackinnonBuck deleted the mbuck/datacontent-fixes branch January 29, 2025 21:44
@github-actions github-actions Bot locked and limited conversation to collaborators Mar 1, 2025
@jeffhandley jeffhandley added the area-ai Microsoft.Extensions.AI libraries label Mar 7, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@eiriktsarpalis eiriktsarpalis eiriktsarpalis left review comments

@stephentoub stephentoub stephentoub approved these changes

Assignees

@MackinnonBuck MackinnonBuck

Labels

area-ai Microsoft.Extensions.AI libraries

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Revisit DataContent and friends

5 participants

@MackinnonBuck @dotnet-comment-bot @stephentoub @eiriktsarpalis @jeffhandley