Fix SQLite decimal comparison with turkish culture #37429

salihozkara · 2025-12-30T16:55:48Z

Summary of the changes

Fixed SQLite decimal collation to use invariant culture for parsing decimal values
Ensured correct decimal comparison in SQLite regardless of the application's current culture

Details

Updated SqliteConnection.CreateCollation to use CultureInfo.InvariantCulture when parsing decimal strings
Added test coverage for decimal ordering with Turkish culture (tr-TR) to verify the fix
The issue occurred when the application culture used a different decimal separator (e.g., comma in Turkish), causing incorrect sorting of decimal values

Fixes

This addresses the issue where SQLite decimal comparison would fail when the application was running under a culture that uses a different decimal separator (e.g., Turkish using comma instead of period).

[release/10.0] Source code updates from dotnet/dotnet

Updated decimal parsing in EF_DECIMAL collation to use CultureInfo.InvariantCulture for consistent ordering across cultures. Added a test to verify correct ordering of decimal values under Turkish culture.

Eliminated the unnecessary 'using System.Globalization;' directive from BuiltInDataTypesSqliteTest.cs to clean up the code.

Copilot

Pull request overview

This PR fixes a culture-specific bug in SQLite decimal comparison where using Turkish culture (or any culture with a different decimal separator) would cause incorrect sorting of decimal values.

Updated the EF_DECIMAL collation to parse decimal strings using CultureInfo.InvariantCulture
Added comprehensive test coverage for decimal ordering under Turkish culture (tr-TR)

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File	Description
`src/EFCore.Sqlite.Core/Storage/Internal/SqliteRelationalConnection.cs`	Updated the `EF_DECIMAL` collation to use `InvariantCulture` when parsing decimal strings, fixing culture-sensitive comparison issues
`test/EFCore.Sqlite.FunctionalTests/BuiltInDataTypesSqliteTest.cs`	Added test with Turkish culture to verify decimal ordering works correctly regardless of application culture

test/EFCore.Sqlite.FunctionalTests/BuiltInDataTypesSqliteTest.cs

src/EFCore.Sqlite.Core/Storage/Internal/SqliteRelationalConnection.cs

Adjusted the TestDecimal values for test entities in Can_query_OrderBy_decimal_with_Turkish_culture to ensure correct ordering and test coverage.

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.

roji · 2025-12-31T08:19:03Z

Note: I have not opened an issue for this change, as it is a straightforward bug fix with clear scope and implementation.

Can you please open an issue? We try to always have an issue - especially when there's a bug - so that it's clear which release contains what, and when a bug was fixed, etc.

salihozkara · 2026-01-01T19:02:33Z

Note: I have not opened an issue for this change, as it is a straightforward bug fix with clear scope and implementation.

Can you please open an issue? We try to always have an issue - especially when there's a bug - so that it's clear which release contains what, and when a bug was fixed, etc.

#37432

roji

Thanks for submitting a fix! See below for some comments.

roji · 2026-01-01T21:46:56Z

eng/Versions.props


  <PropertyGroup Label="Version settings">
-    <VersionPrefix>10.0.2</VersionPrefix>
+    <VersionPrefix>10.0.3</VersionPrefix>


Please revert, we handle version bumps separately.

This was caused by the base branch change. Please rebase on main

src/EFCore.Sqlite.Core/Storage/Internal/SqliteRelationalConnection.cs

roji · 2026-01-01T21:48:28Z

test/EFCore.Sqlite.FunctionalTests/BuiltInDataTypesSqliteTest.cs

    }

+    [ConditionalFact, UseCulture("tr-TR")]
+    public virtual void Can_query_OrderBy_decimal_with_Turkish_culture()


Can you please reduce this test to the bare minimum, removing all the unneeded stuff? Check out the minimal repro posted here.

…tion.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.

salihozkara · 2026-01-03T08:15:36Z

#37443

roji · 2026-01-03T08:29:19Z

@salihozkara there's generally no need to open a new PR, you can always push-force a branch into the PR, replacing its contents. Please avoid doing that, as review history is more difficult to track etc.

dotnet-maestro bot and others added 3 commits December 22, 2025 19:59

[release/10.0] Source code updates from dotnet/dotnet (dotnet#37412)

55b5f7d

[release/10.0] Source code updates from dotnet/dotnet

[release/10.0] Source code updates from dotnet/dotnet (dotnet#37421)

d7a0830

[release/10.0] Source code updates from dotnet/dotnet

Ensure decimal collation uses invariant culture

ac4d0ea

Updated decimal parsing in EF_DECIMAL collation to use CultureInfo.InvariantCulture for consistent ordering across cultures. Added a test to verify correct ordering of decimal values under Turkish culture.

Copilot AI review requested due to automatic review settings December 30, 2025 16:55

salihozkara requested a review from a team as a code owner December 30, 2025 16:55

Copilot started reviewing on behalf of salihozkara December 30, 2025 16:56 View session

Remove unused using directive in test file

4a2a691

Eliminated the unnecessary 'using System.Globalization;' directive from BuiltInDataTypesSqliteTest.cs to clean up the code.

Copilot AI reviewed Dec 30, 2025

View reviewed changes

test/EFCore.Sqlite.FunctionalTests/BuiltInDataTypesSqliteTest.cs Show resolved Hide resolved

src/EFCore.Sqlite.Core/Storage/Internal/SqliteRelationalConnection.cs Outdated Show resolved Hide resolved

Update decimal test values in Turkish culture test

d9d9d96

Adjusted the TestDecimal values for test entities in Can_query_OrderBy_decimal_with_Turkish_culture to ensure correct ordering and test coverage.

AndriySvyryd added the community-contribution label Dec 30, 2025

AndriySvyryd changed the base branch from release/10.0 to main December 30, 2025 20:08

AndriySvyryd requested review from AndriySvyryd and cincuranet as code owners December 30, 2025 20:08

AndriySvyryd self-assigned this Dec 30, 2025

Merge branch 'main' into fix-sqlite-decimal-compare

f5f312f

Copilot AI review requested due to automatic review settings December 31, 2025 01:37

Copilot started reviewing on behalf of AndriySvyryd December 31, 2025 01:38 View session

Copilot AI reviewed Dec 31, 2025

View reviewed changes

roji requested changes Jan 1, 2026

View reviewed changes

Update src/EFCore.Sqlite.Core/Storage/Internal/SqliteRelationalConnec…

c171fd4

…tion.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot AI review requested due to automatic review settings January 2, 2026 06:44

Copilot started reviewing on behalf of salihozkara January 2, 2026 06:44 View session

Copilot AI reviewed Jan 2, 2026

View reviewed changes

AndriySvyryd assigned roji and unassigned AndriySvyryd Jan 2, 2026

salihozkara closed this Jan 3, 2026

Fix SQLite decimal comparison with turkish culture #37429

Fix SQLite decimal comparison with turkish culture #37429

Uh oh!

Conversation

salihozkara commented Dec 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary of the changes

Details

Fixes

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

roji commented Dec 31, 2025

Uh oh!

salihozkara commented Jan 1, 2026

Uh oh!

roji left a comment

Choose a reason for hiding this comment

Uh oh!

roji Jan 1, 2026

Choose a reason for hiding this comment

Uh oh!

AndriySvyryd Jan 2, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

roji Jan 1, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

salihozkara commented Jan 3, 2026

Uh oh!

roji commented Jan 3, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

salihozkara commented Dec 30, 2025 •

edited

Loading