Skip to content

Conversation

@BillWagner
Copy link
Member

@BillWagner BillWagner commented Jan 26, 2026

The Dockerfile for dependabot-bot used the .NET 10 SDK to build the executable, but tried to run that executable on a .NET 9 runtime.

Update the runtime image to .NET 10.

Fix a warning at the same time.

The latest action run failures indicate the same casing is required for FROM and AS.
An exe built with .NET 10 won't run on the .NET 9 runtime.
@BillWagner BillWagner requested a review from a team as a code owner January 26, 2026 15:27
@BillWagner BillWagner requested review from Copilot, gewarren and meaghanlewis and removed request for a team January 26, 2026 15:27
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR aligns Docker build/runtime environments with the .NET 10 target and cleans up Dockerfile syntax to address a warning. It updates dependabot-bot’s runtime image to .NET 10 and normalizes FROM syntax across related Dockerfiles.

Changes:

  • Normalize FROM instructions in sequester.Dockerfile and cleanrepo.Dockerfile to use uppercase AS in the build stage.
  • Update dependabot-bot Dockerfile to use .NET 10 SDK in the final stage while adjusting AS casing in the build stage.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
sequester.Dockerfile Adjusts the build-stage FROM to use uppercase AS for consistency and warning cleanup.
cleanrepo.Dockerfile Same FROM ... AS build-env syntax normalization as sequester.Dockerfile.
actions/dependabot-bot/src/dependabot-bot/Dockerfile Switches the final stage to .NET 10 SDK and normalizes AS keyword in the build stage, but currently leaves the build stage on .NET 9 SDK, which is incompatible with the net10.0 target.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@BillWagner BillWagner merged commit 907378f into dotnet:main Jan 26, 2026
8 of 9 checks passed
@BillWagner BillWagner deleted the Dockerfile-syntax branch January 26, 2026 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants