fix: Cannot read property level of undefined#1357
Merged
anikethsaha merged 4 commits intodocsifyjs:developfrom Sep 1, 2020
Merged
fix: Cannot read property level of undefined#1357anikethsaha merged 4 commits intodocsifyjs:developfrom
anikethsaha merged 4 commits intodocsifyjs:developfrom
Conversation
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/docsify-core/docsify-preview/qen2mxtnq |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit b65fff1:
|
anikethsaha
requested changes
Aug 26, 2020
Member
anikethsaha
left a comment
There was a problem hiding this comment.
Optional Suggestion : Can we have some tests
Koooooo-7
reviewed
Aug 26, 2020
Member
Author
|
@Koooooo-7 You can try it yourself, it causes the sidebar to fail to render here. Run the following README.md: |
Koooooo-7
approved these changes
Aug 29, 2020
anikethsaha
approved these changes
Aug 30, 2020
This was referenced Mar 9, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fix #1356
What kind of change does this PR introduce? (check at least one)
If changing the UI of default theme, please provide the before/after screenshot:
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
fix #xxx[,#xxx], where "xxx" is the issue number)You have tested in the following browsers: (Providing a detailed version will be better.)
If adding a new feature, the PR's description includes:
To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.