opts: deprecate NewNamedListOptsRef, NewNamedMapOpts #6288
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thaJeztah
added
impact/deprecation
status/2-code-review
kind/refactor
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
The `NewNamedListOptsRef`, `NewNamedMapOpts` and related `NamedListOpts`, `NamedMapOpts`, and `NamedOption` interface were added in [moby@677a6b3], which added support for a `daemon.json` configuration file. That change required a way to correlate command-line flags with their corresponding fields in the `daemon.json` to detect conflicting options. At the time, the CLI and daemon were produced from the same code, and shared packages for command-line options, but when the CLI was moved to a separate repository, these options were inherited. [moby@677a6b3]: moby/moby@677a6b3 Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
force-pushed
the
deprecate_opts
branch
from
479b550 to
6f0c66c
Compare
vvoland
approved these changes
Aug 18, 2025
This was referenced Aug 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
NewNamedListOptsRef,NewNamedMapOptsand relatedNamedListOpts,NamedMapOpts, andNamedOptioninterface were added in moby@677a6b3, which added support for adaemon.jsonconfiguration file. That change required a way to correlate command-line flags with their corresponding fields in thedaemon.jsonto detect conflicting options. At the time, the CLI and daemon were produced from the same code, and shared packages for command-line options, but when the CLI was moved to a separate repository, these options were inherited.- Human readable description for the release notes
- A picture of a cute animal (not mandatory but encouraged)