DEV: re-split build vs configure#878
Merged
featheredtoast merged 1 commit intomainfrom Aug 1, 2025
Merged
Conversation
featheredtoast
force-pushed
the
update-build-compile-steps
branch
from
b678c85 to
ce87230
Compare
featheredtoast
changed the title
Member
Author
|
@tgxworld this one allows for precompiling of most assets without connecting to any DBs, leading to very little downtime or changes in base This means the resulting docker layer is much thinner and those booting up from cold boot (with an image only run with |
featheredtoast
added a commit
to discourse/launcher
that referenced
this pull request
Nov 15, 2024
No need to pass SKIP_EMBER_CLI_COMPILE=1 if build/compile split calls different asset:precompile tasks. Depends on discourse/discourse_docker#878
featheredtoast
force-pushed
the
update-build-compile-steps
branch
2 times, most recently
from
37670c0 to
03ceb98
Compare
Member
Author
|
The main piece of this work is in the templates. launcher related patches now here: discourse/launcher#4 |
featheredtoast
force-pushed
the
update-build-compile-steps
branch
from
03ceb98 to
56458bd
Compare
featheredtoast
added a commit
to discourse/launcher
that referenced
this pull request
Jul 9, 2025
No need to pass SKIP_EMBER_CLI_COMPILE=1 if build/compile split calls different asset:precompile tasks. Depends on discourse/discourse_docker#878
featheredtoast
added a commit
to discourse/launcher
that referenced
this pull request
Jul 10, 2025
No need to pass SKIP_EMBER_CLI_COMPILE=1 if build/compile split calls different asset:precompile tasks. Depends on discourse/discourse_docker#878
andrewschleifer
previously requested changes
Jul 24, 2025
Member
|
Do you have an easy way to test the template output? I am simulating it in my head and ... my head is not reliable. |
Member
Author
|
Test part is unfortunately still rather burdensome, for the most part:
|
Allow for assets to be precompiled fully in a build image. The only remaining things for configure is update themes, maxmind download, and css compiling.
featheredtoast
force-pushed
the
update-build-compile-steps
branch
from
56458bd to
d682524
Compare
Member
Author
|
I've narrowed the scope of this, all of the service file updates are now all being done in #967 |
davidtaylorhq
approved these changes
Aug 1, 2025
featheredtoast
dismissed
andrewschleifer’s stale review
Changes requested in review re-implemented to #967
featheredtoast
added a commit
that referenced
this pull request
Aug 1, 2025
This reverts commit f859bee.
featheredtoast
added a commit
that referenced
this pull request
Aug 1, 2025
featheredtoast
added a commit
that referenced
this pull request
Aug 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow for assets to be precompiled fully in a build image.
The only remaining things for configure is update themes, maxmind download, and css compiling.
Moves ~30 seconds of work from a configure step to a build step, allowing for very quick precompile-on-boot times.
Dev:Ensure restarting of the unicorn service on migrate/precompile failure