Fix Clojure v4 strict load error handling - #1775
Open
ThunderRonin wants to merge 2 commits into
Open
ThunderRonin wants to merge 2 commits into
ThunderRonin wants to merge 2 commits into
Conversation
Propagate dynamic load settings into executor workers, abort strict COPY failures after rollback, and surface MSSQL JDBC read errors instead of treating them as EOF or NULL. Add focused unit coverage for strict versus resume behavior and source read failures.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
In the Clojure v4 path,
WITH on error stopcould still enter row rejection, commit the valid part of a failed batch, and exit successfully. MSSQL JDBC row-advance errors were also treated as EOF, while column-read errors became SQL NULL.Change
bound-fnResultSet.nextandgetStringerrorsThis remains batch-transactional rather than globally transactional: batches committed before a later failure are not rolled back.
Reproduction and validation
A two-row MSSQL fixture (
1,not-an-integer) loaded into a PostgreSQL integer column reproduced the bug:Additional isolated validation copied 57 MSSQL tables / 10,115,173 rows through the patched v4 path. Independent all-column reconciliation matched all 57 per-table counts and two domain-separated SHA-256 multiset digests, with no operational timestamp/text discrepancies.
Local checks:
clojure -M:cljfmt check src testclojure -T:build ubermake test-unit— 136 tests, 485 assertions, 0 failures/errorsCloses #1774.