Fix newline handling if using commit_prefix or commit_message
#75
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`git commit` in Ubuntu is not handling `\n` stroke the same way as Alpine. Using `echo -e` will normalize this. This wasn't an issue on Alpine. Added also newline handling to `files_changed` just in case.
github-actions
bot
requested review from
a team and
ChristophShyper
as code owners
ChristophShyper
approved these changes
Nov 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Brief description
Fix newline
commit_prefixorcommit_message💻 Commits
398d405 - Krzysztof Szyper - 2022-11-10 13:37:43
Fix newline
commit_prefixorcommit_messagegit commitin Ubuntu is not handlingUsing
echo -ewill normalize this.This wasn't an issue on Alpine.
Added also newline handling to
files_changedjust in case.📁 Modified files
entrypoint.sh | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
Check CONTRIBUTING.md and CODE_OF_CONDUCT.md for more information