-
Notifications
You must be signed in to change notification settings - Fork 143
Scitags: fallback mechanism #7775
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
virtual organisation. A configurable mapping is used to map VO names to the corresponding experiment IDs. Signed-off-by: Marian Babik <marian.babik@cern.ch>
kofemann
approved these changes
Apr 4, 2025
Member
kofemann
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @marian-babik. The change is good as-is. You can consider the suggested improvements. Otherwise, we are happy to merge it.
modules/dcache/src/main/java/org/dcache/pool/movers/TransferLifeCycle.java
Outdated
Show resolved
Hide resolved
modules/dcache/src/main/java/org/dcache/pool/movers/TransferLifeCycle.java
Outdated
Show resolved
Hide resolved
modules/dcache/src/main/java/org/dcache/pool/movers/TransferLifeCycle.java
Outdated
Show resolved
Hide resolved
Contributor
Author
|
@kofemann Thanks for review, I have done the changes and re-tested. |
kofemann
approved these changes
Apr 4, 2025
Member
|
Thanks, @marian-babik |
marian-babik
added a commit
to marian-babik/dcache
that referenced
this pull request
May 19, 2025
This brings back the fallback mechanism to generate fireflies based on the subject's virtual organisation, even if there are no transfer tags indicated in the protocols. It introduces a default mapping via the configuration variable pool.firefly.vo-mapping Adds fallback mechanism to determine network tags from the Subject's virtual organisation. A configurable mapping is used to map VO names to the corresponding experiment IDs. Signed-off-by: Marian Babik <marian.babik@cern.ch>
kofemann
pushed a commit
to kofemann/dcache
that referenced
this pull request
Jul 14, 2025
This brings back the fallback mechanism to generate fireflies based on the subject's virtual organisation, even if there are no transfer tags indicated in the protocols. It introduces a default mapping via the configuration variable pool.firefly.vo-mapping Adds fallback mechanism to determine network tags from the Subject's virtual organisation. A configurable mapping is used to map VO names to the corresponding experiment IDs. Signed-off-by: Marian Babik <marian.babik@cern.ch> (cherry picked from commit 34658ed) Signed-off-by: Tigran Mkrtchyan <tigran.mkrtchyan@desy.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This brings back the fallback mechanism to generate fireflies based on subject's virtual organisation even if there are no transfer tags indicated in the protocols. It introduces a default mapping via configuration variable pool.firefly.vo-mapping