Repository navigation
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
e11sy
approved these changes
Sep 30, 2026
Reversean
requested changes
Sep 30, 2026
Comment on lines
+203
to
+207
| const sidebarPosition = computed<SidebarPosition>({ | ||
| get: () => noteSettings.value?.sidebarPosition ?? 'content', | ||
| set: (value) => { | ||
| void updateSidebarPosition(props.id, value); | ||
| }, |
Member
There was a problem hiding this comment.
Each selection starts a PATCH without waiting for the previous one, and the response replaces noteSettings. Selecting edge and then none quickly can leave the UI showing edge if the first response arrives last.
Contributor
Author
There was a problem hiding this comment.
Added race condition guard for updateSidebarPosition to prevent this bug
Member
There was a problem hiding this comment.
If the server has content, the user picks edge and then content before response arrives, the second pick is skipped as "already selected", settingsRequestId doesn't change, and the edge response is applied. UI ends up on edge.
Could we also compare with last request value?
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Related with: codex-team/notes.api#306
Adds configurable sidebar positioning for notes and makes the setting apply consistently across parent and child notes.
Changes
Added three sidebar positions:
Added sidebar position controls to the note settings page.
Details
The sidebar position on the page is determined by the sidebarPosition value set on the parent note.
The sidebarPosition value is set via a PATCH /note-settings/:notePublicId request.
the value is obtained from a GET /note-settings/:notePublicId or /note-hierarchy/:notePublicId request. The value used to set the sidebar position is taken from note-hierarchy/.
Disabled sidebar position changes for child notes.