Fix failing tests when ext-xdebug is not loaded and simplify tests for new Xdebug and PHPUnit versions#48
Merged
clue merged 3 commits intoclue:masterfrom Oct 28, 2020
Merged
Conversation
PHP no longer yields a fatal error when ext-xdebug is loaded and an invalid SOAP parameter is encountered. As of ext-xdebug v2.7, this throws a SoapFault as expected. Refs https://bugs.xdebug.org/bug_view_page.php?bug_id=00001629
SimonFrings
approved these changes
Oct 28, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changeset fixes failing tests when ext-xdebug is not loaded and simplifies tests for new Xdebug and PHPUnit versions. This fixes a small oversight from #44. The additional simplification is possible as of #47. The affected tests do not need to be skipped anymore with ext-xdebug 2.7 as per https://bugs.xdebug.org/bug_view_page.php?bug_id=00001629