Skip to content

Run tests on PHPUnit 9#18

Merged
clue merged 2 commits intoclue:masterfrom
SimonFrings:tests
Aug 13, 2020
Merged

Run tests on PHPUnit 9#18
clue merged 2 commits intoclue:masterfrom
SimonFrings:tests

Conversation

@SimonFrings
Copy link
Copy Markdown
Contributor

@SimonFrings SimonFrings commented Aug 5, 2020

For further details concerning this pull request look into graphp/graphviz #46.

Copy link
Copy Markdown
Owner

@clue clue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SimonFrings Thanks for looking into this! Only some minor remarks below

Comment thread tests/TestCase.php Outdated
Comment thread tests/TestCase.php Outdated
@SimonFrings SimonFrings force-pushed the tests branch 2 times, most recently from 50c2667 to d0c3782 Compare August 13, 2020 11:48
@clue clue added this to the v1.3.0 milestone Aug 13, 2020
Copy link
Copy Markdown
Owner

@clue clue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SimonFrings Thanks for the update, changes LGTM! :shipit:

@clue clue merged commit e2e2763 into clue:master Aug 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants