Repository navigation
Revert: #461 - Re-merge OIDC features - #464
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The release notes omit the newly added Buildkite OIDC feature.
1 open finding
What changed in this PR
Adds GCP and Buildkite OIDC credential auto-discovery.
Changes:
- Implements and registers GCP and Buildkite detectors.
- Adds GCP dependencies, tests, and user documentation.
- Expands detector ordering and disable controls.
| File | Description |
|---|---|
uv.lock |
Locks GCP authentication dependencies. |
README.md |
Documents GCP and Buildkite OIDC support. |
pyproject.toml |
Adds the gcp optional dependency. |
cloudsmith_cli/core/tests/test_generic_detector.py |
Accounts for GCP detector precedence. |
cloudsmith_cli/core/tests/test_gcp_detector.py |
Tests GCP credential and token flows. |
cloudsmith_cli/core/tests/test_buildkite_detector.py |
Tests Buildkite detection and token retrieval. |
cloudsmith_cli/core/credentials/oidc/detectors/gcp.py |
Implements GCP OIDC discovery. |
cloudsmith_cli/core/credentials/oidc/detectors/buildkite.py |
Implements Buildkite OIDC discovery. |
cloudsmith_cli/core/credentials/oidc/detectors/__init__.py |
Registers both detectors. |
CHANGELOG.md |
Records GCP support but omits Buildkite. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
coillteoir
approved these changes
Oct 8, 2026
…o the changelog' Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Re-merging @cloudsmith-iduffy's work
Type of Change