Minor fixes to some integration tests - #1364
Merged
Merged
Conversation
InfoTest fails if running against a CF where v2 API is disabled. OrganizationsTest fails when running in kind-deployment landscape. The package "serviceInstances" (with capital "I") does not match the package declaration in the contained class. This creates problems in Eclipse on Windows.
The old docker image was outdated and did not work on recent docker versions. Switching to the image of a better supported test application.
And update documentation in TokensTest.
Kehrlann
reviewed
Jun 29, 2026
Kehrlann
left a comment
Kehrlann
left a comment
Contributor
There was a problem hiding this comment.
Hey @Lokowandtg
Thanks for your contribution. Surprised that some tests (all the .client.v2 and .operations tests) pass without V2, are you using SKIP_V2_TESTS ? And if so, shouldn't InfoTest be skipped?
Comment on lines
+187
to
+199
| assertThat(name) | ||
| .satisfiesAnyOf( | ||
| nameParam -> | ||
| assertThat(nameParam) | ||
| .contains( | ||
| "apps.", | ||
| ".shepherd.tanzu.broadcom.net"), | ||
| nameParam -> | ||
| assertThat(nameParam) | ||
| .contains( | ||
| "apps.", | ||
| ".127-0-0-1.nip.io")); // when | ||
| // testing with kind-deploy. |
Contributor
There was a problem hiding this comment.
Suggestion: Can we infer the domain from the TEST_APIHOST env var?
(Not a hard requirement but it'd be nicer than hardcoding deployment options)
Contributor
Author
There was a problem hiding this comment.
That's a good point. Will do.
Contributor
There was a problem hiding this comment.
Doesn't work on my setup:
[ERROR] Run 1: OrganizationsTest.lambda$getDefaultDomain$7:189
Expecting actual:
"apps.tas.b225eb9d.shepherd.tanzu.broadcom.net"
to contain:
["apps.", ".sys.tas.b225eb9d.shepherd.tanzu.broadcom.net"]
but could not find:
[".sys.tas.b225eb9d.shepherd.tanzu.broadcom.net"]
Contributor
Author
There was a problem hiding this comment.
Fixed. As there is no way to derive the default domain from the ApiHost, I just check that the endpoint returns something.
Kehrlann
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
InfoTest fails if running against a CF where v2 API is disabled.
OrganizationsTest.getDefaultDomain fails when running in kind-deployment landscape.
The package "serviceInstances" (with capital "I") does not match the package declaration in the contained class. This creates problems in Eclipse on Windows.
Fixes #1363