fix(agents): preserve fiber result when cleanup fails - #2244
Merged
Merged
Conversation
A failure deleting the legacy runFiber bookkeeping row could replace the fiber body's successful result. Treat finalization as best-effort, log the failure, and leave the row for the existing recovery pass. Fixes #2104
🦋 Changeset detectedLatest commit: c9992ae The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
There was a problem hiding this comment.
🔍 Devin Review: 1 flag
Not posted on this PR by your GitHub settings — view it in Devin Review. (Configure)
Contributor
🟡 agents import sizesMeasured 336 runtime imports as minified bundles. The primary size is gzip; raw minified size is included for diagnosis. An existing import growing by more than 10% is marked red. This report is informational.
Compared Changed imports (52)
All 336 current runtime imports
Reported by agent-think[bot]. |
agents
@cloudflare/ai-chat
@cloudflare/codemode
hono-agents
@cloudflare/shell
@cloudflare/think
@cloudflare/voice
@cloudflare/worker-bundler
commit: |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
runFiberbookkeeping row as best-effort finalization.cf_agents_runsdelete.Proof
The regression calls public
runFiberthroughTestRunFiberAgent. Its body returns"completed", while a SQLite trigger raisesSQLITE_CONSTRAINT_TRIGGERduring finalization.Before the fix, the RPC rejected with the cleanup
SqlError:After the fix, the test proves all three observable outcomes:
runFiberreturns"completed".Validation
run-fiber.test.ts: 49/49 passed.pnpm run check: exports, formatting, lint, and all 119 TypeScript projects passed.agentspackage build passed.Fixes #2104